Skip to content

Commit 73df027

Browse files
fixing breakage from SqlAlchemy 1.4
1 parent 53f37b9 commit 73df027

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,4 @@ $RECYCLE.BIN/
150150

151151
# Windows shortcuts
152152
*.lnk
153+
.vscode/settings.json

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
attrs
2-
sqlalchemy
2+
SQLAlchemy>=1.4.0
33
pathlib_mate
44
requests

uszipcode/pkg/sqlalchemy_mate/pt.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
from sqlalchemy import select, Table
99
from sqlalchemy.orm import sessionmaker, Query
10-
from sqlalchemy.ext.declarative.api import DeclarativeMeta
10+
from sqlalchemy.orm import DeclarativeMeta
1111
from sqlalchemy.sql.selectable import Select
12-
from sqlalchemy.engine.result import ResultProxy
12+
from sqlalchemy.engine.result import Result
1313

1414
try:
1515
from .utils import execute_query_return_result_proxy
@@ -34,7 +34,7 @@ def from_sql(sql, engine, limit=None):
3434
.. note::
3535
3636
注意, from_db_cursor是从原生的数据库游标通过调用fetchall()方法来获取数据。
37-
而sqlalchemy返回的是ResultProxy类。所以我们需要从中获取游标
37+
而sqlalchemy返回的是Result类。所以我们需要从中获取游标
3838
至于为什么不能直接使用 from_db_cursor(engine.execute(sql).cursor) 的语法
3939
我也不知道为什么.
4040
"""
@@ -144,7 +144,7 @@ def from_everything(everything, engine, limit=None):
144144
if isinstance(everything, Select):
145145
return from_sql(everything, engine, limit=limit)
146146

147-
if isinstance(everything, ResultProxy):
147+
if isinstance(everything, Result):
148148
return from_resultproxy(everything)
149149

150150
if isinstance(everything, list):

0 commit comments

Comments
 (0)