Merge pull request #336 from Azdaroth/fix-validation-message-attribute-format

fix validation error message attribute format

Author: lgebhardt

lib/jsonapi/exceptions.rb

@@ -323,10 +323,11 @@ def json_api_error(attr_key, message)
       end
 
       def pointer(attr_or_relationship_name)
+        formatted_attr_or_relationship_name = format_key(attr_or_relationship_name)
         if resource_relationships.include?(attr_or_relationship_name)
-          "/data/relationships/#{attr_or_relationship_name}"
+          "/data/relationships/#{formatted_attr_or_relationship_name}"
         else
-          "/data/attributes/#{attr_or_relationship_name}"
+          "/data/attributes/#{formatted_attr_or_relationship_name}"
         end
       end
     end

test/controllers/controller_test.rb

@@ -2159,11 +2159,8 @@ def test_create_simple_namespaced
 end
 
 class FactsControllerTest < ActionController::TestCase
-  def setup
-    JSONAPI.configuration.json_key_format = :camelized_key
-  end
-
   def test_type_formatting
+    JSONAPI.configuration.json_key_format = :camelized_key
     get :show, {id: '1'}
     assert_response :success
     assert json_response['data'].is_a?(Hash)
@@ -2177,6 +2174,40 @@ def test_type_formatting
     assert_equal 'abc', json_response['data']['attributes']['photo']
     assert_equal false, json_response['data']['attributes']['cool']
   end
+
+  def test_create_with_invalid_data
+    JSONAPI.configuration.json_key_format = :dasherized_key
+    set_content_type_header!
+    post :create,
+         {
+           data: {
+             type: 'facts',
+             attributes: {
+               bio: '',
+               :"quality-rating" => '',
+               :"spouse-name" => '',
+               salary: 100000,
+               :"date-time-joined" => '',
+               birthday: '',
+               bedtime: '',
+               photo: 'abc',
+               cool: false
+             },
+             relationships: {
+             }
+           }
+         }
+
+    assert_response :unprocessable_entity
+
+    assert_equal "/data/attributes/spouse-name", json_response['errors'][0]['source']['pointer']
+    assert_equal "can't be blank", json_response['errors'][0]['detail']
+    assert_equal "spouse-name - can't be blank", json_response['errors'][0]['title']
+
+    assert_equal "/data/attributes/bio", json_response['errors'][1]['source']['pointer']
+    assert_equal "can't be blank", json_response['errors'][1]['detail']
+    assert_equal "bio - can't be blank", json_response['errors'][1]['title']
+  end
 end
 
 class Api::V2::BooksControllerTest < ActionController::TestCase

test/fixtures/active_record.rb

@@ -303,6 +303,7 @@ class Preferences < ActiveRecord::Base
 end
 
 class Fact < ActiveRecord::Base
+  validates :spouse_name, :bio, presence: true
 end
 
 class Like < ActiveRecord::Base