Merge pull request #224 from togglepro/has_many_association_filters

Use resource_class of relationship to apply filters, etc.

Author: lgebhardt

lib/jsonapi/resource.rb

@@ -589,9 +589,9 @@ def _associate(klass, *attrs)
               resources = []
               if resource_class
                 records = public_send(associated_records_method_name)
-                records = self.class.apply_filters(records, filters)
-                records = self.class.apply_sort(records, self.class.construct_order_options(sort_criteria))
-                records = self.class.apply_pagination(records, paginator)
+                records = resource_class.apply_filters(records, filters)
+                records = resource_class.apply_sort(records, self.class.construct_order_options(sort_criteria))
+                records = resource_class.apply_pagination(records, paginator)
                 records.each do |record|
                   resources.push resource_class.new(record, @context)
                 end

test/fixtures/active_record.rb

@@ -537,6 +537,8 @@ class CommentResource < JSONAPI::Resource
   has_one :post
   has_one :author, class_name: 'Person'
   has_many :tags
+
+  filters :body
 end
 
 class TagResource < JSONAPI::Resource

test/unit/resource/resource_test.rb

@@ -135,4 +135,84 @@ def test_find_by_key_with_customized_base_records
   def test_updateable_fields_does_not_include_id
     assert(!CatResource.updateable_fields.include?(:id))
   end
+
+  def test_has_many_association_filters
+    post_resource = PostResource.new(Post.find(1))
+    comments = post_resource.comments
+    assert_equal(2, comments.size)
+
+    # define apply_filters method on post resource to not respect filters
+    PostResource.instance_eval do
+      def apply_filters(records, filters)
+        records
+      end
+    end
+
+    filtered_comments = post_resource.comments({ filters: { body: 'i liked it' } })
+    assert_equal(1, filtered_comments.size)
+
+    # reset method to original implementation
+    PostResource.instance_eval do
+      def apply_filters(records, filters)
+        super
+      end
+    end
+  end
+
+  def test_has_many_association_sorts
+    post_resource = PostResource.new(Post.find(1))
+    comment_ids = post_resource.comments.map{|c| c.model.id }
+    assert_equal [1,2], comment_ids
+
+    # define apply_filters method on post resource to not respect filters
+    PostResource.instance_eval do
+      def apply_sort(records, criteria)
+        records
+      end
+    end
+
+    sorted_comment_ids = post_resource.comments(sort_criteria: [{ field: 'id', direction: 'desc'}]).map{|c| c.model.id }
+    assert_equal [2,1], sorted_comment_ids
+
+    # reset method to original implementation
+    PostResource.instance_eval do
+      def apply_sort(records, criteria)
+        super
+      end
+    end
+  end
+
+  def test_has_many_association_pagination
+    post_resource = PostResource.new(Post.find(1))
+    comments = post_resource.comments
+    assert_equal 2, comments.size
+
+    # define apply_filters method on post resource to not respect filters
+    PostResource.instance_eval do
+      def apply_pagination(records, criteria)
+        records
+      end
+    end
+
+    paginator_class = Class.new(JSONAPI::Paginator) do
+      def initialize(params)
+        # param parsing and validation here
+        @page = params.to_i
+      end
+
+      def apply(relation)
+        relation.offset(@page).limit(1)
+      end
+    end
+
+    paged_comments = post_resource.comments(paginator: paginator_class.new(1))
+    assert_equal 1, paged_comments.size
+
+    # reset method to original implementation
+    PostResource.instance_eval do
+      def apply_pagination(records, criteria)
+        super
+      end
+    end
+  end
 end