Renamed has_one direction option to foreign_key_on. Options are :self and :related_resource

Author: lgebhardt

README.md

@@ -247,7 +247,7 @@ The association methods support the following options:
  * `relation_name` - the name of the relation to use on the model. A lambda may be provided which allows conditional selection of the relation based on the context.
 
 `has_one` associations support the additional option:
- * `direction` - defaults to `:belongs_to`. To indicate that the underlying model association is a `has_one` relationship specify `:reverse`.
+ * `foreign_key_on` - defaults to `:self`. To indicate that the foreign key is on the related resource specify `:related_resource`.
 
 Examples:
 

lib/jsonapi/association.rb

@@ -46,18 +46,18 @@ def type_for_source(source)
     end
 
     class HasOne < Association
-      attr_reader :direction
+      attr_reader :foreign_key_on
 
       def initialize(name, options = {})
         super
         @class_name = options.fetch(:class_name, name.to_s.camelize)
         @type = class_name.underscore.pluralize.to_sym
         @foreign_key ||= "#{name}_id".to_sym
-        @direction = options.fetch(:direction, :belongs_to)
+        @foreign_key_on = options.fetch(:foreign_key_on, :self)
       end
 
       def belongs_to?
-        direction == :belongs_to
+        foreign_key_on == :self
       end
 
       def polymorphic_type

test/fixtures/active_record.rb

@@ -1093,7 +1093,7 @@ class AuthorResource < JSONAPI::Resource
       attributes :name, :email
       model_name 'Person'
       has_many :posts
-      has_one :author_detail, direction: :reverse
+      has_one :author_detail, foreign_key_on: :related_resource
 
       filter :name