Skip to content

Commit 0ddd5c3

Browse files
committed
Merge pull request #312 from cerebris/fix_engine_check
Fix issue where a nil engine name isn't being cached so it was being reevaluated repeatedly. Was slowing down large result sets by about 4X.
2 parents 9f58ec5 + 8f5c7af commit 0ddd5c3

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/jsonapi-resources.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@
2020
require 'jsonapi/operation_result'
2121
require 'jsonapi/operation_results'
2222
require 'jsonapi/callbacks'
23+
require 'jsonapi/link_builder'

lib/jsonapi/link_builder.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ def initialize(config = {})
88
@base_url = config[:base_url]
99
@primary_resource_klass = config[:primary_resource_klass]
1010
@route_formatter = config[:route_formatter]
11+
@is_engine = !!engine_name
1112
end
1213

1314
def engine?
14-
!!engine_name
15+
@is_engine
1516
end
1617

1718
def engine_name

lib/jsonapi/resource_serializer.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require_relative "link_builder"
2-
31
module JSONAPI
42
class ResourceSerializer
53

0 commit comments

Comments
 (0)