Skip to content

Commit c2efd74

Browse files
committed
scope handling fix (wip)
1 parent fb1af6f commit c2efd74

4 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/main/java/org/htmlunit/javascript/DebugFrameAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import org.htmlunit.corejs.javascript.Context;
1818
import org.htmlunit.corejs.javascript.Scriptable;
19+
import org.htmlunit.corejs.javascript.VarScope;
1920
import org.htmlunit.corejs.javascript.debug.DebugFrame;
2021

2122
/**
@@ -35,7 +36,7 @@ public void onDebuggerStatement(final Context cx) {
3536

3637
/** {@inheritDoc} */
3738
@Override
38-
public void onEnter(final Context cx, final Scriptable activation, final Scriptable thisObj, final Object[] args) {
39+
public void onEnter(final Context cx, final VarScope activation, final Scriptable thisObj, final Object[] args) {
3940
// Empty.
4041
}
4142

src/main/java/org/htmlunit/javascript/DebugFrameImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.htmlunit.corejs.javascript.NativeFunction;
2626
import org.htmlunit.corejs.javascript.Scriptable;
2727
import org.htmlunit.corejs.javascript.ScriptableObject;
28+
import org.htmlunit.corejs.javascript.VarScope;
2829
import org.htmlunit.corejs.javascript.debug.DebuggableScript;
2930
import org.htmlunit.javascript.host.event.Event;
3031

@@ -74,7 +75,7 @@ public DebugFrameImpl(final DebuggableScript functionOrScript) {
7475
* {@inheritDoc}
7576
*/
7677
@Override
77-
public void onEnter(final Context cx, final Scriptable activation, final Scriptable thisObj, final Object[] args) {
78+
public void onEnter(final Context cx, final VarScope activation, final Scriptable thisObj, final Object[] args) {
7879
if (LOG.isTraceEnabled()) {
7980
final StringBuilder sb = new StringBuilder();
8081

src/main/java/org/htmlunit/javascript/host/WindowOrWorkerGlobalScopeMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ private WindowOrWorkerGlobalScopeMixin() {
5757
/**
5858
* Decodes a string of data which has been encoded using base-64 encoding.
5959
* @param encodedData the encoded string
60-
* @param scriptable the HtmlUnitScriptable scope
60+
* @param scriptable the HtmlUnitScriptable
6161
* @return the decoded value
6262
*/
6363
public static String atob(final String encodedData, final HtmlUnitScriptable scriptable) {
@@ -77,7 +77,7 @@ public static String atob(final String encodedData, final HtmlUnitScriptable scr
7777
/**
7878
* Creates a base-64 encoded ASCII string from a string of binary data.
7979
* @param stringToEncode string to encode
80-
* @param scriptable the HtmlUnitScriptable scope
80+
* @param scriptable the HtmlUnitScriptable
8181
* @return the encoded string
8282
*/
8383
public static String btoa(final String stringToEncode, final HtmlUnitScriptable scriptable) {

src/main/java/org/htmlunit/javascript/host/xml/FormData.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public FormDataIterator(final String className) {
9797
* @param type the type
9898
* @param nameValuePairList the list of name value pairs
9999
*/
100-
public FormDataIterator(final Scriptable scope, final String className, final Type type,
100+
public FormDataIterator(final VarScope scope, final String className, final Type type,
101101
final List<NameValuePair> nameValuePairList) {
102102
super(scope, FORM_DATA_TAG);
103103
type_ = type;
@@ -298,7 +298,8 @@ public void set(final String name, final Object value, final Object filename) {
298298
@JsxFunction
299299
@JsxSymbol(symbolName = "iterator")
300300
public Scriptable entries() {
301-
return new FormDataIterator(this, "FormData Iterator", FormDataIterator.Type.BOTH, requestParameters_);
301+
return new FormDataIterator(getParentScope(),
302+
"FormData Iterator", FormDataIterator.Type.BOTH, requestParameters_);
302303
}
303304

304305
/**

0 commit comments

Comments
 (0)