Skip to content

Commit 75d0f22

Browse files
committed
Firefox 149, Chrome 147
1 parent f8a22e4 commit 75d0f22

3 files changed

Lines changed: 28 additions & 10 deletions

File tree

src/main/java/org/htmlunit/javascript/host/WebSocket.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,14 @@ public void onWebSocketText(final String message) {
154154
msgEvent.setParentScope(scope);
155155
msgEvent.setPrototype(getPrototype(msgEvent.getClass()));
156156
if (originSet_) {
157-
msgEvent.setOrigin(getUrl());
157+
try {
158+
URL originUrl = UrlUtils.toUrlUnsafe(getUrl());
159+
originUrl = UrlUtils.getUrlWithoutPathRefQuery(originUrl);
160+
msgEvent.setOrigin(originUrl.toExternalForm());
161+
}
162+
catch (final MalformedURLException e) {
163+
// ignore
164+
}
158165
}
159166
msgEvent.setSrcElement(WebSocket.this);
160167
fire(msgEvent);
@@ -172,7 +179,14 @@ public void onWebSocketBinary(final byte[] data, final int offset, final int len
172179
msgEvent.setParentScope(scope);
173180
msgEvent.setPrototype(getPrototype(msgEvent.getClass()));
174181
if (originSet_) {
175-
msgEvent.setOrigin(getUrl());
182+
try {
183+
URL originUrl = UrlUtils.toUrlUnsafe(getUrl());
184+
originUrl = UrlUtils.getUrlWithoutPathRefQuery(originUrl);
185+
msgEvent.setOrigin(originUrl.toExternalForm());
186+
}
187+
catch (final MalformedURLException e) {
188+
// ignore
189+
}
176190
}
177191
msgEvent.setSrcElement(WebSocket.this);
178192
fire(msgEvent);

src/test/java/org/htmlunit/javascript/host/WebSocketTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -489,26 +489,26 @@ public void events() throws Exception {
489489
"onOpen", "open", "[object WebSocket]", "[object WebSocket]",
490490
"undefined", "undefined", "undefined", "undefined",
491491
"onMessageTextListener", "message", "[object WebSocket]", "[object WebSocket]",
492-
"server_text", "§§URL§§/ws", "", "null",
492+
"server_text", "§§URL§§", "", "null",
493493
"onMessageText", "message", "[object WebSocket]", "[object WebSocket]",
494-
"server_text", "§§URL§§/ws", "", "null",
494+
"server_text", "§§URL§§", "", "null",
495495
"onMessageBinaryListener", "message", "[object WebSocket]", "[object WebSocket]",
496-
"[object ArrayBuffer]", "§§URL§§/ws", "", "null",
496+
"[object ArrayBuffer]", "§§URL§§", "", "null",
497497
"onMessageBinary", "message", "[object WebSocket]", "[object WebSocket]",
498-
"[object ArrayBuffer]", "§§URL§§/ws", "", "null",
498+
"[object ArrayBuffer]", "§§URL§§", "", "null",
499499
"onCloseListener code: 1000 wasClean: true",
500500
"onClose code: 1000 wasClean: true"},
501501
FF_ESR = {"onOpenListener",
502502
"onOpen", "open", "[object WebSocket]", "[object WebSocket]",
503503
"undefined", "undefined", "undefined", "undefined",
504504
"onMessageTextListener", "message", "[object WebSocket]", "[object WebSocket]",
505-
"server_text", "§§URL§§/ws", "", "null",
505+
"server_text", "§§URL§§", "", "null",
506506
"onMessageText", "message", "[object WebSocket]", "[object WebSocket]",
507-
"server_text", "§§URL§§/ws", "", "null",
507+
"server_text", "§§URL§§", "", "null",
508508
"onMessageBinaryListener", "message", "[object WebSocket]", "[object WebSocket]",
509-
"[object ArrayBuffer]", "§§URL§§/ws", "", "null",
509+
"[object ArrayBuffer]", "§§URL§§", "", "null",
510510
"onMessageBinary", "message", "[object WebSocket]", "[object WebSocket]",
511-
"[object ArrayBuffer]", "§§URL§§/ws", "", "null",
511+
"[object ArrayBuffer]", "§§URL§§", "", "null",
512512
"onCloseListener code: 1000 wasClean: true",
513513
"onClose code: 1000 wasClean: true"})
514514
public void wasClean() throws Exception {

src/test/java/org/htmlunit/javascript/host/Window2Test.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -984,6 +984,8 @@ public void heightsAndWidths() throws Exception {
984984
EDGE = {"true", "0", "137", "true", "true", "24"},
985985
FF = {"true", "0", "94", "true", "true", "16"},
986986
FF_ESR = {"true", "0", "94", "true", "true", "16"})
987+
@HtmlUnitNYI(CHROME = {"true", "0", "147", "true", "true", "16"},
988+
EDGE = {"true", "0", "138", "true", "true", "24"})
987989
public void heightsAndWidthsQuirks() throws Exception {
988990
final String html =
989991
"<html><body onload='test()'><script>\n"
@@ -1047,6 +1049,7 @@ public void setInnerHeight() throws Exception {
10471049
EDGE = {"true", "1234"},
10481050
FF = {"true", "1234"},
10491051
FF_ESR = {"true", "1234"})
1052+
@HtmlUnitNYI(CHROME = {"true", "1234"})
10501053
public void setOuterWidth() throws Exception {
10511054
final String html = DOCTYPE_HTML
10521055
+ "<html><body onload='test()'><script>\n"
@@ -1069,6 +1072,7 @@ public void setOuterWidth() throws Exception {
10691072
EDGE = {"true", "1234"},
10701073
FF = {"true", "1234"},
10711074
FF_ESR = {"true", "1234"})
1075+
@HtmlUnitNYI(CHROME = {"true", "1234"})
10721076
public void setOuterHeight() throws Exception {
10731077
final String html = DOCTYPE_HTML
10741078
+ "<html><body onload='test()'><script>\n"

0 commit comments

Comments
 (0)