diff --git a/.checks/wcag-report.json b/.checks/wcag-report.json
index 5675119..7c2497a 100644
--- a/.checks/wcag-report.json
+++ b/.checks/wcag-report.json
@@ -4,7 +4,7 @@
"id": "color-contrast",
"impact": "serious",
"description": "Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
- "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/color-contrast?application=webdriverjs",
+ "helpUrl": "https://dequeuniversity.com/rules/axe/4.12/color-contrast?application=webdriverjs",
"nodes": [
{
"target": [
@@ -20,7 +20,7 @@
"id": "scrollable-region-focusable",
"impact": "serious",
"description": "Ensure elements that have scrollable content are accessible by keyboard in Safari",
- "helpUrl": "https://dequeuniversity.com/rules/axe/4.11/scrollable-region-focusable?application=webdriverjs",
+ "helpUrl": "https://dequeuniversity.com/rules/axe/4.12/scrollable-region-focusable?application=webdriverjs",
"nodes": [
{
"target": [
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index c0fd98f..008348d 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -167,7 +167,7 @@ jobs:
- name: Generate GitHub App token
id: app-token
- uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ secrets.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
diff --git a/.github/workflows/update-workflows.yml b/.github/workflows/update-workflows.yml
index 7b00f4d..252622c 100644
--- a/.github/workflows/update-workflows.yml
+++ b/.github/workflows/update-workflows.yml
@@ -25,7 +25,7 @@ jobs:
- name: Maak GitHub App token aan voor Geonovum
id: token-geonovum
- uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ secrets.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
@@ -34,7 +34,7 @@ jobs:
- name: Maak GitHub App token aan voor BROprogramma
id: token-broprogramma
continue-on-error: true
- uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ secrets.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
@@ -90,7 +90,7 @@ jobs:
- name: Maak GitHub App token aan voor ${{ matrix.org }}
id: token
- uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
+ uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
client-id: ${{ secrets.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
diff --git a/snapshot.html b/snapshot.html
index e990ad6..b5161b1 100644
--- a/snapshot.html
+++ b/snapshot.html
@@ -1,7 +1,7 @@
-
+
A
B
C
D
+
A
B
C
D
Figuur 2 Mermaid voorbeeld
@@ -1546,11 +1579,12 @@
↑
-
+
Referenced in:
@@ -1573,8 +1607,11 @@
}
function panelListener() {
- /** @type {HTMLElement} */
+ /** @type {HTMLElement | null} */
let panel = null;
+ /**
+ * @param {KeyboardEvent|MouseEvent} event
+ */
return event => {
const { target, type } = event;
@@ -1582,24 +1619,34 @@
// For keys, we only care about Enter key to activate the panel
// otherwise it's activated via a click.
- if (type === "keydown" && event.key !== "Enter") return;
+ if (
+ type === "keydown" &&
+ /** @type {KeyboardEvent} */ (event).key !== "Enter"
+ )
+ return;
const action = deriveAction(event);
switch (action) {
case "show": {
hidePanel(panel);
- /** @type {HTMLElement} */
+ /** @type {HTMLElement | null} */
const dfn = target.closest("dfn, .index-term");
+ if (!dfn?.id) break;
panel = document.getElementById(`dfn-panel-for-${dfn.id}`);
- const coords = deriveCoordinates(event);
+ if (!panel) break;
+ const coords = deriveCoordinates(
+ /** @type {MouseEvent|KeyboardEvent} */ (event)
+ );
displayPanel(dfn, panel, coords);
break;
}
case "dock": {
- panel.style.left = null;
- panel.style.top = null;
- panel.classList.add("docked");
+ if (panel) {
+ panel.style.left = "";
+ panel.style.top = "";
+ panel.classList.add("docked");
+ }
break;
}
case "hide": {
@@ -1650,7 +1697,8 @@
if (hitALink) {
return target.classList.contains("self-link") ? "hide" : "dock";
}
- const panel = target.closest(".dfn-panel");
+
+ const panel = /** @type {HTMLElement} */ (target.closest(".dfn-panel"));
return panel.classList.contains("docked") ? "hide" : "none";
}
if (document.querySelector(".dfn-panel:not([hidden])")) {
@@ -1694,9 +1742,9 @@
const newLeft = Math.max(MARGIN, x + MARGIN - panelRect.width);
const newCaretOffset = left - newLeft;
panel.style.left = `${newLeft}px`;
- /** @type {HTMLElement} */
+ /** @type {HTMLElement | null} */
const caret = panel.querySelector(".caret");
- caret.style.left = `${newCaretOffset}px`;
+ if (caret) caret.style.left = `${newCaretOffset}px`;
}
// As it's a dialog, we trap focus.
@@ -1745,6 +1793,9 @@
function createTrapListener(anchors, panel, dfn) {
const lastIndex = anchors.length - 1;
let currentIndex = 0;
+ /**
+ * @param {KeyboardEvent} event
+ */
return event => {
switch (event.key) {
// Hitting "Tab" traps us in a nice loop around elements.
@@ -1774,7 +1825,7 @@
};
}
-/** @param {HTMLElement} panel */
+/** @param {HTMLElement | null} panel */
function hidePanel(panel) {
if (!panel) return;
panel.hidden = true;