chore: remove react external

Author: sylingd

rsbuild.config.ts

@@ -56,10 +56,6 @@ export default defineConfig({
         }
         callback();
       },
-      {
-        react: 'React',
-        'react-dom': 'ReactDOM',
-      },
     ],
   },
   dev: {
@@ -68,10 +64,10 @@ export default defineConfig({
     liveReload: false,
   },
   performance: {
-    // bundleAnalyze: {
-    //   analyzerMode: 'static',
-    //   openAnalyzer: false,
-    // },
+    bundleAnalyze: {
+      analyzerMode: 'static',
+      openAnalyzer: false,
+    },
   },
   tools: {
     swc: {
@@ -123,18 +119,6 @@ export default defineConfig({
           popup: './src/pages/popup/index.tsx',
         },
       },
-      output: {
-        copy: [
-          {
-            from: `./node_modules/react/umd/react.${isDev ? 'development' : 'production.min'}.js`,
-            to: 'external/react.js',
-          },
-          {
-            from: `./node_modules/react-dom/umd/react-dom.${isDev ? 'development' : 'production.min'}.js`,
-            to: 'external/react-dom.js',
-          },
-        ],
-      },
       performance: {
         chunkSplit: {
           strategy: 'split-by-experience',
@@ -162,22 +146,6 @@ export default defineConfig({
             children:
               'body{margin:0;background-color:var(--semi-color-bg-0);color:var(--semi-color-text-0)}',
           },
-          {
-            tag: 'script',
-            head: true,
-            append: false,
-            attrs: {
-              src: 'external/react.js',
-            },
-          },
-          {
-            tag: 'script',
-            head: true,
-            append: false,
-            attrs: {
-              src: 'external/react-dom.js',
-            },
-          },
         ],
       },
       plugins: [pluginReact()],

scripts/pack-utils/xpi.mjs

@@ -34,12 +34,12 @@ async function packXpi({
   if (downloadedFiles.length === 0) {
     throw new Error('No signed addon found');
   }
-  console.log(`Downloaded signed addon: ${downloadedFiles.join(', ')}`);
+  console.log(`[xpi] Downloaded: ${downloadedFiles.join(', ')}`);
   const fileName = getOutputFile(extensionConfig.browser, version, 'xpi');
-  const out = join(releasePath, fileName);
+  const outFile = join(releasePath, fileName);
   // Move download file to output dir
-  await rename(downloadedFiles[0], out);
-  console.log('Downloaded signed addon');
+  await rename(downloadedFiles[0], outFile);
+  console.log(`[xpi] move to ${outFile}`);
   const infoFile = join(releasePath, `${fileName}-config.json`);
   await outputJSON(infoFile, {
     id: extensionConfig.id,

src/pages/background/core/rules.ts

@@ -1,4 +1,5 @@
-import { cloneDeep, isEqual } from 'lodash-es';
+import isEqual from 'fast-deep-equal';
+import { cloneDeep } from 'lodash-es';
 import {
   APIs,
   EVENTs,

src/share/core/prefs.ts

@@ -1,7 +1,7 @@
-import equal from 'fast-deep-equal';
+import isEqual from 'fast-deep-equal';
 import browser from 'webextension-polyfill';
-import emitter from './emitter';
 import { defaultPrefValue } from './constant';
+import emitter from './emitter';
 import { getSync } from './storage';
 import type { PrefValue } from './types';
 
@@ -15,13 +15,13 @@ class Prefs {
   constructor() {
     this.values = { ...defaultPrefValue };
 
-    Object.entries(defaultPrefValue).forEach((it) => {
+    Object.entries(defaultPrefValue).forEach(it => {
       this.set(it[0], it[1], true);
     });
 
     getSync()
       .get('settings')
-      .then((result) => {
+      .then(result => {
         const synced: any = result.settings;
         for (const key in defaultPrefValue) {
           if (synced && key in synced) {
@@ -49,7 +49,10 @@ class Prefs {
     });
   }
 
-  get<K extends keyof PrefValue>(key: K, defaultValue?: PrefValue[K]): PrefValue[K] {
+  get<K extends keyof PrefValue>(
+    key: K,
+    defaultValue?: PrefValue[K],
+  ): PrefValue[K] {
     if (key in this.boundMethods) {
       if (key in this.boundWrappers) {
         return this.boundWrappers[key];
@@ -72,9 +75,9 @@ class Prefs {
   }
 
   set(key: string, value: any, noSync = false) {
-    const oldValue = this.values[key];
-    if (!equal(value, oldValue)) {
-      this.values[key] = value;
+    const oldValue = this.values[key as keyof PrefValue];
+    if (!isEqual(value, oldValue)) {
+      (this.values as any)[key] = value;
       emitter.emit(emitter.EVENT_PREFS_UPDATE, key, value);
       if (!noSync) {
         getSync().set({