feat(mixer): add AFL on every aux master and group bus#594
Open
srperens wants to merge 1 commit into
Open
Conversation
Per-bus AFL taps post-master, post-mute from each aux/group output tee into the existing solo_mixer, sharing the same monitor-source gating as channel PFL/AFL. The state layer treats auxN_afl / groupN_afl writes as solo-affecting so the monitor gates refresh once per batch alongside the existing chN_pfl / chN_afl path. Frontend adds an AFL button under Mute on each aux/group strip and extends the Clear-all batch to release bus AFLs in the same PATCH. PFL is intentionally not exposed on buses (bus faders are essentially always up); the auxN_afl / groupN_afl namespace leaves room for *_pfl later without a breaking change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aux{N}_out_tee/group{K}_out_teepost-master, post-mute through avolumegate +queueintosolo_mixer; newauxN_afl/groupN_aflBool properties arelive: true,persist: Some(false)and use the existingbool_to_volumetransformis_solo_property_name(renamed fromparse_solo_property_name) now matches aux/group AFL so the state layer's solo-intent cache and monitor-gate refresh handle bus AFL with the same single-batch atomicity as channel solos*_aflnamespace leaves room for*_pfllater without a breaking changeTest plan
cargo checkclean on workspacecargo test --lib mixer— 88 passed (including updatedtest_mixer_pfl_afl_are_transientcovering the new aux/group AFL props and rewrittentest_is_solo_property_name_matches_pfl_and_afl)cargo fmt --all+ clippy clean (pre-commit hook)🤖 Generated with Claude Code