Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd dependencies argument from Money Request headers, preview, and primary actions.
Scope (9 files)
MoneyReportHeaderActions/MoneyReportHeaderSecondaryActions
MoneyReportHeaderActions/MoneyReportHeaderSelectionDropdown
MoneyReportHeaderPrimaryAction/SubmitPrimaryAction
ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewProvider
ReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButton
ReportActionItem/MoneyRequestReportPreview/SubmitActionButton
hooks/useLifecycleActions
pages/ReportSubmitToContent
TransactionItemRow/DataCells/ChatBubbleCell
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open an IOU/expense report; verify Pay/Approve/Submit dropdowns and KYC gating; report preview card in chat; submit primary action; chat-bubble cell in transaction rows.
Acceptance criteria
npm run fmt on changed files
npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
npm run typecheck stays green
npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
- Relevant
npm run test for touched areas
- Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue Owner
Current Issue Owner: @hoangzinh
Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd
dependenciesargument from Money Request headers, preview, and primary actions.Scope (9 files)
MoneyReportHeaderActions/MoneyReportHeaderSecondaryActionsMoneyReportHeaderActions/MoneyReportHeaderSelectionDropdownMoneyReportHeaderPrimaryAction/SubmitPrimaryActionReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewProviderReportActionItem/MoneyRequestReportPreview/ReportPreviewActionButtonReportActionItem/MoneyRequestReportPreview/SubmitActionButtonhooks/useLifecycleActionspages/ReportSubmitToContentTransactionItemRow/DataCells/ChatBubbleCellDependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open an IOU/expense report; verify Pay/Approve/Submit dropdowns and KYC gating; report preview card in chat; submit primary action; chat-bubble cell in transaction rows.
Acceptance criteria
npm run fmton changed filesnpm run lint-changed— seatbelt count forrulesdir/no-useonyx-dependencies-argmust drop (never increase)npm run typecheckstays greennpm run react-compiler-compliance-check check <files>— USECALLBACK/bailout files must not gain new failures vsmainnpm run testfor touched areasIssue Owner
Current Issue Owner: @hoangzinh