From a5966825cac440ce086ad20937c9700637db46a8 Mon Sep 17 00:00:00 2001
From: Brian Foley <bpfoley@gmail.com>
Date: Mon, 14 Sep 2026 22:17:31 +0100
Subject: [PATCH] Handle missing components returned by `parse_url()`

Found by `phpstan analyze --level 7`
---
 pinc/RandomRule.inc  | 6 +++++-
 pinc/metarefresh.inc | 6 +++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/pinc/RandomRule.inc b/pinc/RandomRule.inc
index ca3fa2911..e88c1f0ab 100644
--- a/pinc/RandomRule.inc
+++ b/pinc/RandomRule.inc
@@ -269,7 +269,11 @@ class RandomRule
                     return '<a href="' . $url . $match[1] . '"';
                 } elseif (str_starts_with($match[1], '/')) {
                     $url_parts = parse_url($url);
-                    return '<a href="' . $url_parts["scheme"] . "://" . $url_parts["host"] . $match[1] . '"';
+                    if (($scheme = $url_parts["scheme"] ?? "")) {
+                        $scheme .= "://";
+                    }
+                    $host = $url_parts["host"] ?? "";
+                    return '<a href="' . $scheme . $host . $match[1] . '"';
                 } elseif (!str_starts_with($match[1], 'http')) {
                     $base_url = dirname($url) . '/';
                     return '<a href="' . $base_url . $match[1] . '"';
diff --git a/pinc/metarefresh.inc b/pinc/metarefresh.inc
index 67648911f..e7892c32d 100644
--- a/pinc/metarefresh.inc
+++ b/pinc/metarefresh.inc
@@ -41,9 +41,9 @@ function metarefresh(int $seconds, string $url, string $title = "", string $body
     $absolute_url_parts = parse_url($absolute_url);
     $code_url_parts = parse_url($code_url);
     if (!$allow_external && !(
-        ($absolute_url_parts["scheme"] == $code_url_parts["scheme"]) &&
-        ($absolute_url_parts["host"] == $code_url_parts["host"]) &&
-        (($absolute_url_parts["port"] ?? "") == ($code_url_parts["port"] ?? ""))
+        ($absolute_url_parts["scheme"] ?? null) === ($code_url_parts["scheme"] ?? null) &&
+        ($absolute_url_parts["host"] ?? null) === ($code_url_parts["host"] ?? null) &&
+        ($absolute_url_parts["port"] ?? null) === ($code_url_parts["port"] ?? null)
     )) {
         $absolute_url = "$code_url/index.php";
     }