From 0ce022265bbc6805aef10f9551ce956de704e03b Mon Sep 17 00:00:00 2001 From: Philip Lee Date: Mon, 24 Aug 2026 16:49:04 -0400 Subject: [PATCH] Rename get_default_config to get_default_metrics in redis_cloud/redis_enterprise checks Both RedisCloudCheck and RedisEnterpriseCheck defined a get_default_config() method returning a list of metric groups. A newer datadog-checks-base adds its own get_default_config() to OpenMetricsBaseCheckV2, used internally by get_config_with_defaults() to seed scraper config from the generated config_models defaults (expects key/value pairs, not a metrics list). The override shadows the base method, so get_config_with_defaults() calls the check's version instead and dict() blows up trying to consume a list of metric dicts as key/value pairs. Co-Authored-By: Claude Sonnet 5 --- redis_cloud/datadog_checks/redis_cloud/check.py | 4 ++-- redis_enterprise/datadog_checks/redis_enterprise/check.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/redis_cloud/datadog_checks/redis_cloud/check.py b/redis_cloud/datadog_checks/redis_cloud/check.py index 07b7737c99..627e4845af 100644 --- a/redis_cloud/datadog_checks/redis_cloud/check.py +++ b/redis_cloud/datadog_checks/redis_cloud/check.py @@ -16,7 +16,7 @@ def __init__(self, name, init_config, instances): def _parse_config(self): self.scraper_configs = [] metrics_endpoint = self.instance.get('openmetrics_endpoint') - metrics = self.get_default_config() + metrics = self.get_default_metrics() additional = [] groups = self.instance.get('extra_metrics', []) @@ -49,7 +49,7 @@ def _parse_config(self): config.update(self.instance) self.scraper_configs.append(config) - def get_default_config(self): + def get_default_metrics(self): metrics = [] for dm in DEFAULT_METRICS: metrics.append(dm) diff --git a/redis_enterprise/datadog_checks/redis_enterprise/check.py b/redis_enterprise/datadog_checks/redis_enterprise/check.py index 21ed97c325..840c2e1cba 100644 --- a/redis_enterprise/datadog_checks/redis_enterprise/check.py +++ b/redis_enterprise/datadog_checks/redis_enterprise/check.py @@ -17,7 +17,7 @@ def _parse_config(self): self.scraper_configs = [] metrics_endpoint = self.instance.get('openmetrics_endpoint') self.instance.setdefault("tls_verify", True) - metrics = self.get_default_config() + metrics = self.get_default_metrics() additional = [] groups = self.instance.get('extra_metrics', []) @@ -50,7 +50,7 @@ def _parse_config(self): config.update(self.instance) self.scraper_configs.append(config) - def get_default_config(self): + def get_default_metrics(self): metrics = [] for dm in DEFAULT_METRICS: metrics.append(dm)