Skip to content

Commit beec5f6

Browse files
committed
Cargo: Update mctp-rs dependencies to 5a7b9067b4a4
Account for some API changes made since 77da3b1c4d35 ("pldm-file: remove Responder::init_read"). Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
1 parent 15d9c4d commit beec5f6

4 files changed

Lines changed: 25 additions & 17 deletions

File tree

Cargo.lock

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ repository = "https://github.com/CodeConstruct/mctp-dev"
88
categories = ["network-programming", "hardware-support"]
99

1010
[features]
11+
default = ["nvme-mi", "pldm"]
1112
nvme-mi = ["dep:nvme-mi-dev"]
1213
pldm = ["dep:hex", "dep:pldm", "dep:pldm-file", "dep:pldm-platform", "dep:sha2"]
1314

@@ -25,12 +26,12 @@ futures-io = "0.3.30"
2526
hex = { version = "0.4.3", optional = true }
2627
log = "0.4.28"
2728
mctp = "0.2.0"
28-
mctp-estack = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "77da3b1c4d35b7c9ba37747da968d29fc4cde696", package = "mctp-estack" }
29+
mctp-estack = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "5a7b9067b4a4515b05ef8b5f4948ba542e8ae1c9", package = "mctp-estack" }
2930
nvme-mi-dev = { version = "0.1.0", optional = true }
3031
polling = "3.7.4"
31-
pldm = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "77da3b1c4d35b7c9ba37747da968d29fc4cde696", package = "pldm", optional = true }
32-
pldm-file = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "77da3b1c4d35b7c9ba37747da968d29fc4cde696", package = "pldm-file", optional = true }
33-
pldm-platform = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "77da3b1c4d35b7c9ba37747da968d29fc4cde696", package = "pldm-platform", optional = true }
32+
pldm = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "5a7b9067b4a4515b05ef8b5f4948ba542e8ae1c9", package = "pldm", optional = true }
33+
pldm-file = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "5a7b9067b4a4515b05ef8b5f4948ba542e8ae1c9", package = "pldm-file", optional = true }
34+
pldm-platform = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "5a7b9067b4a4515b05ef8b5f4948ba542e8ae1c9", package = "pldm-platform", optional = true }
3435
sha2 = {version = "0.10.9", optional = true }
3536
simplelog = "0.12.2"
3637
smol = "2.0.0"
@@ -39,4 +40,4 @@ uuid = { version = "1.16.0", features = ["v4"] }
3940

4041
# update nvme-mi-dev mctp dependency
4142
[patch.crates-io]
42-
mctp = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "77da3b1c4d35b7c9ba37747da968d29fc4cde696", package = "mctp" }
43+
mctp = { git = "https://github.com/CodeConstruct/mctp-rs", rev = "5a7b9067b4a4515b05ef8b5f4948ba542e8ae1c9", package = "mctp" }

src/pldm.rs

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,20 @@ use pldm_file::{
1212
};
1313
use pldm_platform::{proto::PdrRecord, requester as platrq};
1414

15+
const MULTIPART_PART_SIZE: u16 = 512;
16+
1517
async fn pldm_control(chan: &mut impl mctp::AsyncReqChannel) -> Result<()> {
1618
let req_types = [pldm_file::PLDM_TYPE_FILE_TRANSFER];
1719
let mut buf = [0u8];
1820

19-
let (size, neg_types) =
20-
negotiate_transfer_parameters(chan, &req_types, &mut buf, 512)
21-
.await
22-
.context("Negotiate transfer parameters failed")?;
21+
let (size, neg_types) = negotiate_transfer_parameters(
22+
chan,
23+
&req_types,
24+
&mut buf,
25+
MULTIPART_PART_SIZE,
26+
)
27+
.await
28+
.context("Negotiate transfer parameters failed")?;
2329

2430
debug!("Negotiated multipart size {size} for types {neg_types:?}");
2531

@@ -75,7 +81,8 @@ async fn pldm_file(
7581
let mut cur_len = 0usize;
7682

7783
debug!("Reading...");
78-
let res = df_read_with(chan, fd, 0, req_len, |part| {
84+
let mut part = [0u8; { MULTIPART_PART_SIZE as usize + 18 }];
85+
let res = df_read_with(chan, fd, 0, req_len, &mut part, |part| {
7986
cur_len += part.len();
8087
debug!(" {} bytes, {cur_len}/{req_len}", part.len());
8188
if cur_len > req_len {

src/usbredir.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,7 @@ impl MctpUsbRedir {
428428
pub async fn send(&mut self, pkt: &[u8]) -> mctp::Result<()> {
429429
let total = pkt.len().checked_add(4).ok_or(mctp::Error::NoSpace)?;
430430
let mut tx_buf = Vec::with_capacity(total);
431-
let mut hdr = [0u8; 4];
432-
MctpUsbHandler::header(pkt.len(), &mut hdr)?;
431+
let hdr = MctpUsbHandler::header(pkt.len())?;
433432
tx_buf.extend_from_slice(&hdr);
434433
tx_buf.extend_from_slice(pkt);
435434
self.xfer_tx_chan

0 commit comments

Comments
 (0)