Skip employees when percentageOfFullTime is zero (#7)

* Skip employees when percentageOfFullTime is zero

* Update version number for XML comments

* Tweak full time check

Author: steve-sullivan

config/settings.yml

@@ -6,7 +6,7 @@ settings:
   upload_host: "upload.lib.berkeley.edu"
   upload_user: "ssullivan"
   last_alma_purge: "2023-06-30"
-  application_version: "1.6.5"
+  application_version: "1.6.6"
 
 # TODO - flesh this out
 # http://docopt.org/

config/ucpath_fields.yml

@@ -201,11 +201,7 @@ job:
       dbdef: "VARCHAR(16)"
       status: OPTIONAL
 
-# Needed....?
-# EmployeeIDs:
-#   employee_rootnode: "//ar:response/emp:employees/emp:employee"
-#   total_records_xpath: "//ar:offset/ar:total"
-#   remaining_records_xpath: "//ar:offset/ar:remaining"
-#   next_records_xpath: "//ar:offset/ar:next"
-#   previous_records_xpath: "//ar:offset/ar:previous"
-#   employee_id_xpath: "./p:identifiers/r:identifier[r:type/text()='hr-employee-id']/r:id"
+    - name: percent_of_fulltime
+      jpath: "$.position.percentOfFullTime"
+      dbdef: "VARCHAR(16)"
+      status: OPTIONAL

lib/ucpath/jobs.rb

@@ -69,26 +69,44 @@ def choose_job(job1, job2)
     end
 
     def eligible?(j)
-      # There are 3 conditions that determine if a job is "not eligible":
-      # 1. hrStatus/code = A
-      return false unless j.hr_status_code == 'A'
+      # There are 4 conditions that determine if a job is "not eligible":
+      return false unless active_job?(j)
+      return false unless valid_expected_end_date?(j)
+      return false unless valid_org_relationship?(j)
+      return false unless positive_full_time?(j)
 
-      # 2. If their Job record has an expectedEndDate, it must be on or after today's date.
+      # If we got this far the job is eligible - hooray!
+      true
+    end
+
+    # 1. hrStatus/code = A
+    def active_job?(j)
+      j.hr_status_code == 'A'
+    end
+
+    # 2. If their Job record has an expectedEndDate, it must be on or after today's date.
+    def valid_expected_end_date?(j)
       end_date_str = j.expected_end_date.to_s
-      return false if end_date_str != '' && Date.iso8601(end_date_str) <= Date.today
+      return true if end_date_str.empty?
 
-      # 3. If their organizationRelationship/code = 'CWR' their jobCode must be within
-      #    the Visiting Scholar category
-      #    or UCB Academic Dept Affiliate Code (per SD-97)
-      if j.org_relationship_code == 'CWR'
-        visiting_scholar = Config.check_ucpath_code('visiting_scholar_job_code', j.job_code)
-        academic_affiliate = Config.check_ucpath_code('ucb_academic_dept_affiliate_code', j.job_code)
+      Date.iso8601(end_date_str) > Date.today
+    end
 
-        return false unless visiting_scholar || academic_affiliate
-      end
+    # 3. If their organizationRelationship/code = 'CWR' their jobCode must be within
+    #    the Visiting Scholar category
+    #    or UCB Academic Dept Affiliate Code (per SD-97)
+    def valid_org_relationship?(j)
+      return true unless j.org_relationship_code == 'CWR'
 
-      # If we got this far the job is eligible - hooray!
-      true
+      visiting_scholar = Config.check_ucpath_code('visiting_scholar_job_code', j.job_code)
+      academic_affiliate = Config.check_ucpath_code('ucb_academic_dept_affiliate_code', j.job_code)
+
+      visiting_scholar || academic_affiliate
+    end
+
+    # 4. The job will be ineligible if the percentage of full time is zero
+    def positive_full_time?(j)
+      j.percent_of_fulltime.to_f.positive?
     end
 
     def find_priority_jobs(job_list)

lib/ucpath/user.rb

@@ -143,6 +143,15 @@ def create_user_record
 
       job_code = jobs.job.job_code || nil
       priority_job = Config.check_ucpath_code('priority_job_codes', job_code)
+      percent_of_fulltime = jobs.job.percent_of_fulltime.to_f
+
+      # PERCENT OF FULL TIME CHECK
+      # AP-559 If an employee is in a position that is 0 FTE,
+      # their record should should be filtered out from the UCPath files.
+      if percent_of_fulltime.zero?
+        logger.info "#{id} - Ineligible: Percentage of Full Time Check: #{percent_of_fulltime}"
+        return nil
+      end
 
       # STUDENT CHECK - berkeleyeduaffiliations in Student Affiliation (ldap_fields.yml)
       if !priority_job && ldap&.berkeleyeduaffiliations

spec/data/ucpath/generic_jobs_2.json

@@ -18,6 +18,7 @@
               "code": "SMTOC",
               "description": "Simons Institute TOC"
             },
+            "percentOfFullTime": 1.000000,
             "jobCode": {
               "code": {
                 "code": "003252",

spec/lib/ucpath_spec.rb

@@ -603,7 +603,7 @@ def eligible(job)
   # Minimal structs to stand in for your “job” objects
   let(:choose_job_struct) { Struct.new(:expected_end_date) }
   let(:eligible_job_struct) do
-    Struct.new(:hr_status_code, :expected_end_date, :org_relationship_code, :job_code)
+    Struct.new(:hr_status_code, :expected_end_date, :org_relationship_code, :job_code, :percent_of_fulltime)
   end
 
   describe '#choose_job' do
@@ -652,55 +652,55 @@ def eligible(job)
     end
 
     context "when hr_status_code is not 'A'" do
-      let(:job) { eligible_job_struct.new('I', '', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('I', '', '', 'ANY', 1.0) }
 
       it 'returns false' do
         expect(eligible(job)).to be(false)
       end
     end
 
     context "when hr_status_code is 'A' and expected_end_date is blank" do
-      let(:job) { eligible_job_struct.new('A', '', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('A', '', '', 'ANY', 1.0) }
 
       it 'returns true' do
         expect(eligible(job)).to be(true)
       end
     end
 
     context "when hr_status_code is 'A' and expected_end_date is after today" do
-      let(:job) { eligible_job_struct.new('A', '2026-03-01', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('A', '2026-03-01', '', 'ANY', 1.0) }
 
       it 'returns true' do
         expect(eligible(job)).to be(true)
       end
     end
 
     context "when hr_status_code is 'A' and expected_end_date is today" do
-      let(:job) { eligible_job_struct.new('A', '2026-02-23', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('A', '2026-02-23', '', 'ANY', 1.0) }
 
       it 'returns false (<= today is not eligible per implementation)' do
         expect(eligible(job)).to be(false)
       end
     end
 
     context "when hr_status_code is 'A' and expected_end_date is before today" do
-      let(:job) { eligible_job_struct.new('A', '2026-02-01', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('A', '2026-02-01', '', 'ANY', 1.0) }
 
       it 'returns false' do
         expect(eligible(job)).to be(false)
       end
     end
 
     context 'when org_relationship_code is blank and other conditions pass' do
-      let(:job) { eligible_job_struct.new('A', '', '', 'ANY') }
+      let(:job) { eligible_job_struct.new('A', '', '', 'ANY', 1.0) }
 
       it 'returns true' do
         expect(eligible(job)).to be(true)
       end
     end
 
     context "when org_relationship_code is 'CWR' and job_code is NOT in either allowlist" do
-      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'NOT_ALLOWED') }
+      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'NOT_ALLOWED', 1.0) }
 
       before do
         allow(Config).to receive(:check_ucpath_code)
@@ -718,7 +718,7 @@ def eligible(job)
     end
 
     context "when org_relationship_code is 'CWR' and job_code IS in visiting_scholar_job_code" do
-      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'ALLOWED') }
+      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'ALLOWED', 1.0) }
 
       before do
         allow(Config).to receive(:check_ucpath_code)
@@ -736,7 +736,7 @@ def eligible(job)
     end
 
     context "when org_relationship_code is 'CWR' and job_code IS in ucb_academic_dept_affiliate_code" do
-      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'ALLOWED') }
+      let(:job) { eligible_job_struct.new('A', '', 'CWR', 'ALLOWED', 1.0) }
 
       before do
         allow(Config).to receive(:check_ucpath_code)