fix: resolve TC39 decorator compat issues - use declare without override for type-narrowing fields, fix barrel import, bump dictionary mode threshold

RaananW · RaananW · commit a999fe7fe074 · 2026-03-30T12:52:42.000+02:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dev/core/src/Layers/highlightLayer.ts b/packages/dev/core/src/Layers/highlightLayer.ts
@@ -63,7 +63,7 @@ interface IBlurPostProcess extends PostProcess {
  * It enforces keeping the most luminous color in the color channel.
  */
 class GlowBlurPostProcess extends PostProcess {
-    declare protected override _effectWrapper: ThinGlowBlurPostProcess;
+    declare protected _effectWrapper: ThinGlowBlurPostProcess;
 
     constructor(
         name: string,
diff --git a/packages/dev/core/src/PostProcesses/blackAndWhitePostProcess.ts b/packages/dev/core/src/PostProcesses/blackAndWhitePostProcess.ts
@@ -35,7 +35,7 @@ export class BlackAndWhitePostProcess extends PostProcess {
         return "BlackAndWhitePostProcess";
     }
 
-    declare protected override _effectWrapper: ThinBlackAndWhitePostProcess;
+    declare protected _effectWrapper: ThinBlackAndWhitePostProcess;
 
     /**
      * Creates a black and white post process
diff --git a/packages/dev/core/src/PostProcesses/bloomMergePostProcess.ts b/packages/dev/core/src/PostProcesses/bloomMergePostProcess.ts
@@ -32,7 +32,7 @@ export class BloomMergePostProcess extends PostProcess {
         return "BloomMergePostProcess";
     }
 
-    declare protected override _effectWrapper: ThinBloomMergePostProcess;
+    declare protected _effectWrapper: ThinBloomMergePostProcess;
 
     /**
      * Creates a new instance of @see BloomMergePostProcess
diff --git a/packages/dev/core/src/PostProcesses/blurPostProcess.ts b/packages/dev/core/src/PostProcesses/blurPostProcess.ts
@@ -67,7 +67,7 @@ export class BlurPostProcess extends PostProcess {
         return "BlurPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinBlurPostProcess;
+    declare protected _effectWrapper: ThinBlurPostProcess;
 
     /**
      * Creates a new instance BlurPostProcess
diff --git a/packages/dev/core/src/PostProcesses/chromaticAberrationPostProcess.ts b/packages/dev/core/src/PostProcesses/chromaticAberrationPostProcess.ts
@@ -93,7 +93,7 @@ export class ChromaticAberrationPostProcess extends PostProcess {
         return "ChromaticAberrationPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinChromaticAberrationPostProcess;
+    declare protected _effectWrapper: ThinChromaticAberrationPostProcess;
 
     /**
      * Creates a new instance ChromaticAberrationPostProcess
diff --git a/packages/dev/core/src/PostProcesses/circleOfConfusionPostProcess.ts b/packages/dev/core/src/PostProcesses/circleOfConfusionPostProcess.ts
@@ -75,7 +75,7 @@ export class CircleOfConfusionPostProcess extends PostProcess {
         return "CircleOfConfusionPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinCircleOfConfusionPostProcess;
+    declare protected _effectWrapper: ThinCircleOfConfusionPostProcess;
     private _depthTexture: Nullable<RenderTargetTexture> = null;
 
     /**
diff --git a/packages/dev/core/src/PostProcesses/colorCorrectionPostProcess.ts b/packages/dev/core/src/PostProcesses/colorCorrectionPostProcess.ts
@@ -43,7 +43,7 @@ export class ColorCorrectionPostProcess extends PostProcess {
         return "ColorCorrectionPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinColorCorrectionPostProcess;
+    declare protected _effectWrapper: ThinColorCorrectionPostProcess;
 
     constructor(
         name: string,
diff --git a/packages/dev/core/src/PostProcesses/convolutionPostProcess.ts b/packages/dev/core/src/PostProcesses/convolutionPostProcess.ts
@@ -37,7 +37,7 @@ export class ConvolutionPostProcess extends PostProcess {
         return "ConvolutionPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinConvolutionPostProcess;
+    declare protected _effectWrapper: ThinConvolutionPostProcess;
 
     /**
      * Creates a new instance ConvolutionPostProcess
diff --git a/packages/dev/core/src/PostProcesses/extractHighlightsPostProcess.ts b/packages/dev/core/src/PostProcesses/extractHighlightsPostProcess.ts
@@ -50,7 +50,7 @@ export class ExtractHighlightsPostProcess extends PostProcess {
         return "ExtractHighlightsPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinExtractHighlightsPostProcess;
+    declare protected _effectWrapper: ThinExtractHighlightsPostProcess;
 
     constructor(
         name: string,
diff --git a/packages/dev/core/src/PostProcesses/filterPostProcess.ts b/packages/dev/core/src/PostProcesses/filterPostProcess.ts
@@ -34,7 +34,7 @@ export class FilterPostProcess extends PostProcess {
         return "FilterPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinFilterPostProcess;
+    declare protected _effectWrapper: ThinFilterPostProcess;
 
     /**
      *
diff --git a/packages/dev/core/src/PostProcesses/fxaaPostProcess.ts b/packages/dev/core/src/PostProcesses/fxaaPostProcess.ts
@@ -25,7 +25,7 @@ export class FxaaPostProcess extends PostProcess {
         return "FxaaPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinFXAAPostProcess;
+    declare protected _effectWrapper: ThinFXAAPostProcess;
 
     constructor(
         name: string,
diff --git a/packages/dev/core/src/PostProcesses/grainPostProcess.ts b/packages/dev/core/src/PostProcesses/grainPostProcess.ts
@@ -48,7 +48,7 @@ export class GrainPostProcess extends PostProcess {
         return "GrainPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinGrainPostProcess;
+    declare protected _effectWrapper: ThinGrainPostProcess;
 
     /**
      * Creates a new instance of @see GrainPostProcess
diff --git a/packages/dev/core/src/PostProcesses/imageProcessingPostProcess.ts b/packages/dev/core/src/PostProcesses/imageProcessingPostProcess.ts
@@ -319,7 +319,7 @@ export class ImageProcessingPostProcess extends PostProcess {
         this._effectWrapper.fromLinearSpace = value;
     }
 
-    declare protected override _effectWrapper: ThinImageProcessingPostProcess;
+    declare protected _effectWrapper: ThinImageProcessingPostProcess;
 
     constructor(
         name: string,
diff --git a/packages/dev/core/src/PostProcesses/motionBlurPostProcess.ts b/packages/dev/core/src/PostProcesses/motionBlurPostProcess.ts
@@ -107,7 +107,7 @@ export class MotionBlurPostProcess extends PostProcess {
         return "MotionBlurPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinMotionBlurPostProcess;
+    declare protected _effectWrapper: ThinMotionBlurPostProcess;
 
     /**
      * Creates a new instance MotionBlurPostProcess
diff --git a/packages/dev/core/src/PostProcesses/passPostProcess.ts b/packages/dev/core/src/PostProcesses/passPostProcess.ts
@@ -116,7 +116,7 @@ export class PassCubePostProcess extends PostProcess {
         return "PassCubePostProcess";
     }
 
-    declare protected override _effectWrapper: ThinPassCubePostProcess;
+    declare protected _effectWrapper: ThinPassCubePostProcess;
 
     /**
      * Creates the PassCubePostProcess
diff --git a/packages/dev/core/src/PostProcesses/screenSpaceCurvaturePostProcess.ts b/packages/dev/core/src/PostProcesses/screenSpaceCurvaturePostProcess.ts
@@ -56,7 +56,7 @@ export class ScreenSpaceCurvaturePostProcess extends PostProcess {
         return "ScreenSpaceCurvaturePostProcess";
     }
 
-    declare protected override _effectWrapper: ThinScreenSpaceCurvaturePostProcess;
+    declare protected _effectWrapper: ThinScreenSpaceCurvaturePostProcess;
 
     /**
      * Creates a new instance ScreenSpaceCurvaturePostProcess
diff --git a/packages/dev/core/src/PostProcesses/sharpenPostProcess.ts b/packages/dev/core/src/PostProcesses/sharpenPostProcess.ts
@@ -51,7 +51,7 @@ export class SharpenPostProcess extends PostProcess {
         return "SharpenPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinSharpenPostProcess;
+    declare protected _effectWrapper: ThinSharpenPostProcess;
 
     /**
      * Creates a new instance ConvolutionPostProcess
diff --git a/packages/dev/core/src/PostProcesses/tonemapPostProcess.ts b/packages/dev/core/src/PostProcesses/tonemapPostProcess.ts
@@ -47,7 +47,7 @@ export class TonemapPostProcess extends PostProcess {
         return "TonemapPostProcess";
     }
 
-    declare protected override _effectWrapper: ThinTonemapPostProcess;
+    declare protected _effectWrapper: ThinTonemapPostProcess;
 
     /**
      * Creates a new TonemapPostProcess
diff --git a/packages/dev/core/test/unit/Meshes/babylon.dictionaryMode.test.ts b/packages/dev/core/test/unit/Meshes/babylon.dictionaryMode.test.ts
@@ -33,7 +33,7 @@ describe("Babylon Mesh", () => {
                 }
             }
 
-            expect(count).toBeLessThan(128);
+            expect(count).toBeLessThan(136);
         });
     });
 });
diff --git a/packages/dev/smartFilters/test/unit/customShaderBlock.test.ts b/packages/dev/smartFilters/test/unit/customShaderBlock.test.ts

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export class BlackAndWhitePostProcess extends PostProcess {`
`35`	`35`	`return "BlackAndWhitePostProcess";`
`36`	`36`	`}`
`37`	`37`
`38`		`- declare protected override _effectWrapper: ThinBlackAndWhitePostProcess;`
	`38`	`+ declare protected _effectWrapper: ThinBlackAndWhitePostProcess;`
`39`	`39`
`40`	`40`	`/**`
`41`	`41`	`* Creates a black and white post process`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export class BloomMergePostProcess extends PostProcess {`
`32`	`32`	`return "BloomMergePostProcess";`
`33`	`33`	`}`
`34`	`34`
`35`		`- declare protected override _effectWrapper: ThinBloomMergePostProcess;`
	`35`	`+ declare protected _effectWrapper: ThinBloomMergePostProcess;`
`36`	`36`
`37`	`37`	`/**`
`38`	`38`	`* Creates a new instance of @see BloomMergePostProcess`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export class BlurPostProcess extends PostProcess {`
`67`	`67`	`return "BlurPostProcess";`
`68`	`68`	`}`
`69`	`69`
`70`		`- declare protected override _effectWrapper: ThinBlurPostProcess;`
	`70`	`+ declare protected _effectWrapper: ThinBlurPostProcess;`
`71`	`71`
`72`	`72`	`/**`
`73`	`73`	`* Creates a new instance BlurPostProcess`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export class ChromaticAberrationPostProcess extends PostProcess {`
`93`	`93`	`return "ChromaticAberrationPostProcess";`
`94`	`94`	`}`
`95`	`95`
`96`		`- declare protected override _effectWrapper: ThinChromaticAberrationPostProcess;`
	`96`	`+ declare protected _effectWrapper: ThinChromaticAberrationPostProcess;`
`97`	`97`
`98`	`98`	`/**`
`99`	`99`	`* Creates a new instance ChromaticAberrationPostProcess`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export class CircleOfConfusionPostProcess extends PostProcess {`
`75`	`75`	`return "CircleOfConfusionPostProcess";`
`76`	`76`	`}`
`77`	`77`
`78`		`- declare protected override _effectWrapper: ThinCircleOfConfusionPostProcess;`
	`78`	`+ declare protected _effectWrapper: ThinCircleOfConfusionPostProcess;`
`79`	`79`	`private _depthTexture: Nullable<RenderTargetTexture> = null;`
`80`	`80`
`81`	`81`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export class ColorCorrectionPostProcess extends PostProcess {`
`43`	`43`	`return "ColorCorrectionPostProcess";`
`44`	`44`	`}`
`45`	`45`
`46`		`- declare protected override _effectWrapper: ThinColorCorrectionPostProcess;`
	`46`	`+ declare protected _effectWrapper: ThinColorCorrectionPostProcess;`
`47`	`47`
`48`	`48`	`constructor(`
`49`	`49`	`name: string,`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export class ConvolutionPostProcess extends PostProcess {`
`37`	`37`	`return "ConvolutionPostProcess";`
`38`	`38`	`}`
`39`	`39`
`40`		`- declare protected override _effectWrapper: ThinConvolutionPostProcess;`
	`40`	`+ declare protected _effectWrapper: ThinConvolutionPostProcess;`
`41`	`41`
`42`	`42`	`/**`
`43`	`43`	`* Creates a new instance ConvolutionPostProcess`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export class ExtractHighlightsPostProcess extends PostProcess {`
`50`	`50`	`return "ExtractHighlightsPostProcess";`
`51`	`51`	`}`
`52`	`52`
`53`		`- declare protected override _effectWrapper: ThinExtractHighlightsPostProcess;`
	`53`	`+ declare protected _effectWrapper: ThinExtractHighlightsPostProcess;`
`54`	`54`
`55`	`55`	`constructor(`
`56`	`56`	`name: string,`