chore: improved tsconfig settings

BenjaminSchwendner · BenjaminSchwendner · commit da3018aa3068 · 2026-03-18T11:13:13.000+05:30
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -15,6 +15,11 @@ supportedArchitectures:
     - darwin
 
 npmMinimalAgeGate: '7d'
+
+packageExtensions:
+  "@types/apollo-upload-client@*":
+    peerDependencies:
+      "@apollo/client": "*"
 npmPreapprovedPackages:
   - '@axinom/*'
 
diff --git a/libs/media-messages/tsconfig.json b/libs/media-messages/tsconfig.json
@@ -4,17 +4,16 @@
     "strict": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "esModuleInterop": true, // Needed to be able to import 'postgraphile-plugin-connection-filter'
-    "allowSyntheticDefaultImports": true, // Needed to be able to import 'ajv' together with esModuleInterop
     "outDir": "./dist",
     "resolveJsonModule": true,
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
     "removeComments": true,
     "sourceMap": true,
     "skipLibCheck": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true
   },
   "exclude": [
@@ -23,9 +22,5 @@
     "scripts",
     "*/tests",
     "**/*spec.ts"
-  ],
-  "watchOptions": {
-    "watchFile": "dynamicPriorityPolling",
-    "watchDirectory": "dynamicPriorityPolling",
-  }
+  ]
 }
diff --git a/services/catalog/service/tsconfig.build.json b/services/catalog/service/tsconfig.build.json
@@ -2,7 +2,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "noEmit": false
+    "noEmit": false,
+    "removeComments": true
   },
   "exclude": [
     "node_modules",
diff --git a/services/catalog/service/tsconfig.json b/services/catalog/service/tsconfig.json
@@ -4,25 +4,20 @@
     "strict": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "esModuleInterop": true, // Needed to be able to import 'postgraphile-plugin-connection-filter'
-    "allowSyntheticDefaultImports": true, // Needed to be able to import 'ajv' together with esModuleInterop
     "outDir": "./dist",
     "resolveJsonModule": true,
     "noEmit": true,
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
-    "removeComments": true,
     "sourceMap": true,
     "skipLibCheck": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true
   },
   "exclude": [
     "node_modules",
     "dist"
-  ],
-  "watchOptions": {
-    "watchFile": "fixedPollingInterval"
-  }
+  ]
 }
diff --git a/services/channel/service/tsconfig.build.json b/services/channel/service/tsconfig.build.json
@@ -2,7 +2,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "noEmit": false
+    "noEmit": false,
+    "removeComments": true
   },
   "exclude": [
     "node_modules",
diff --git a/services/channel/service/tsconfig.json b/services/channel/service/tsconfig.json
@@ -6,24 +6,18 @@
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "esModuleInterop": true, // Needed to be able to import 'postgraphile-plugin-connection-filter'
-    "allowSyntheticDefaultImports": true, // Needed to be able to import 'ajv' together with esModuleInterop
     "outDir": "./dist",
     "resolveJsonModule": true,
     "noEmit": true,
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
-    "removeComments": true,
     "skipLibCheck": true,
     "sourceMap": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true
   },
   "exclude": [
     "node_modules",
     "dist"
-  ],
-  "watchOptions": {
-    "watchFile": "fixedPollingInterval"
-  }
+  ]
 }
diff --git a/services/channel/workflows/tsconfig.json b/services/channel/workflows/tsconfig.json
@@ -3,7 +3,6 @@
     "declaration": true,
     "noImplicitAny": false,
     "removeComments": false,
-    "noLib": false,
     "target": "es6",
     "sourceMap": true,
     "outDir": "./dist",
@@ -12,12 +11,12 @@
       "dom",
       "es2018"
     ],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "module": "esnext",
     "jsx": "react",
     "importHelpers": true,
     "strict": true,
-    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
     "resolveJsonModule": true
   },
   "include": [
diff --git a/services/entitlement/service/tsconfig.build.json b/services/entitlement/service/tsconfig.build.json
@@ -2,7 +2,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "noEmit": false
+    "noEmit": false,
+    "removeComments": true
   },
   "exclude": [
     "node_modules",
diff --git a/services/entitlement/service/tsconfig.json b/services/entitlement/service/tsconfig.json
@@ -4,25 +4,20 @@
     "strict": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "esModuleInterop": true, // Needed to be able to import 'postgraphile-plugin-connection-filter'
-    "allowSyntheticDefaultImports": true, // Needed to be able to import 'ajv' together with esModuleInterop
     "outDir": "./dist",
     "resolveJsonModule": true,
     "noEmit": true,
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
-    "removeComments": true,
     "sourceMap": true,
     "skipLibCheck": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true
   },
   "exclude": [
     "node_modules",
     "dist"
-  ],
-  "watchOptions": {
-    "watchFile": "fixedPollingInterval"
-  }
+  ]
 }
diff --git a/services/media/service/tsconfig.build.json b/services/media/service/tsconfig.build.json
@@ -2,7 +2,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "noEmit": false
+    "noEmit": false,
+    "removeComments": true
   },
   "exclude": [
     "node_modules",
diff --git a/services/media/service/tsconfig.json b/services/media/service/tsconfig.json
@@ -6,24 +6,18 @@
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "esModuleInterop": true, // Needed to be able to import 'postgraphile-plugin-connection-filter'
-    "allowSyntheticDefaultImports": true, // Needed to be able to import 'ajv' together with esModuleInterop
     "outDir": "./dist",
     "resolveJsonModule": true,
     "noEmit": true,
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
-    "removeComments": true,
     "sourceMap": true,
     "skipLibCheck": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true
   },
   "exclude": [
     "node_modules",
     "dist"
-  ],
-  "watchOptions": {
-    "watchFile": "fixedPollingInterval"
-  }
+  ]
 }
diff --git a/services/media/workflows/package.json b/services/media/workflows/package.json
@@ -52,6 +52,7 @@
     "@graphql-codegen/typescript": "^2.7.3",
     "@graphql-codegen/typescript-operations": "^2.5.3",
     "@graphql-codegen/typescript-react-apollo": "^3.3.7",
+    "@types/apollo-upload-client": "^14.1.0",
     "@types/node": "^18.11.19",
     "@types/react": "^17.0.50",
     "@types/react-dom": "^17.0.17",
diff --git a/services/media/workflows/src/apolloClient/customFetch.ts b/services/media/workflows/src/apolloClient/customFetch.ts
@@ -31,7 +31,7 @@ const parseHeaders = (rawHeaders: string): Headers => {
 };
 
 export const uploadFetch = (
-  url: string,
+  url: string | URL | Request,
   options: CustomFetchOptions,
 ): Promise<Response> =>
   new Promise((resolve, reject) => {
@@ -55,11 +55,12 @@ export const uploadFetch = (
     xhr.ontimeout = () => {
       reject(new TypeError('Network request failed'));
     };
-    xhr.open(options.method, url, true);
+    xhr.open(options.method, url instanceof Request ? url.url : url, true);
 
     if (options.headers) {
-      Object.keys(options.headers).forEach((key) => {
-        xhr.setRequestHeader(key, options.headers[key]);
+      const headers = options.headers as Record<string, string>;
+      Object.keys(headers).forEach((key) => {
+        xhr.setRequestHeader(key, headers[key]);
       });
     }
 
@@ -77,11 +78,12 @@ export const uploadFetch = (
   });
 
 export const customFetch = (
-  uri: string,
-  options: CustomFetchOptions,
+  uri: string | URL | Request,
+  options?: RequestInit,
 ): Promise<Response> => {
-  if (options.useUpload) {
-    return uploadFetch(uri, options);
+  const customOptions = options as CustomFetchOptions | undefined;
+  if (customOptions?.useUpload) {
+    return uploadFetch(uri, customOptions);
   }
   return fetch(uri, options);
 };
diff --git a/services/media/workflows/tsconfig.json b/services/media/workflows/tsconfig.json
@@ -3,7 +3,6 @@
     "declaration": true,
     "noImplicitAny": false,
     "removeComments": false,
-    "noLib": false,
     "target": "es6",
     "sourceMap": true,
     "outDir": "./dist",
@@ -12,12 +11,12 @@
       "dom",
       "es2018"
     ],
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "module": "esnext",
     "jsx": "react",
     "importHelpers": true,
     "strict": true,
-    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
     "resolveJsonModule": true
   },
   "include": [
diff --git a/services/vod-to-live/service/tsconfig.json b/services/vod-to-live/service/tsconfig.json
@@ -1,18 +1,16 @@
 {
   "compilerOptions": {
-    "target": "es2018",
+    "target": "es2022",
     "module": "commonjs",
     "declaration": true,
     "sourceMap": true,
-    "baseUrl": "./",
     "preserveWatchOutput": true,
-    "incremental": true,
     "strict": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "esModuleInterop": true,
     "outDir": "./dist",
-    "allowSyntheticDefaultImports": true,
     "skipLibCheck": true
   },
   "include": [
@@ -22,8 +20,5 @@
   "exclude": [
     "node_modules",
     "dist"
-  ],
-  "watchOptions": {
-    "watchFile": "fixedPollingInterval"
-  }
+  ]
 }
diff --git a/yarn.lock b/yarn.lock
