Skip to content

[26.1.2] Game scenes rebuild the entire fake client environment every frame #106

Description

@LegendaryRylex

GuideME Version: 26.1.12-beta

Keeping a guide page with a game scene open makes memory climb continuously, like a leak.

GuidebookLevelRenderer#renderContent calls FakeRenderEnvironment.create() every frame, per visible scene. That builds a new Connection, ClientPacketListener, ClientLevel, and LocalPlayer each time before close() throws it all away.

I've got a local mixing on my end with a fix. I cache it inside FakeRenderEnvironment itself: keep the built graph in a static field together with the RegistryAccess and on create() it rebuilds only when Platform.getClientRegistryAccess() returns a different instance, otherwise just do the existing player swap.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions