adding more (unit) test coverage

Author: lsulak

agent/src/test/scala/za/co/absa/atum/agent/model/PartitioningCreateRequestUnitTests.scala

@@ -0,0 +1,47 @@
+/*
+ * Copyright 2021 ABSA Group Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package za.co.absa.atum.agent.model
+
+import org.scalatest.funsuite.AnyFunSuiteLike
+import za.co.absa.atum.model.dto.{PartitioningDTO, PartitionDTO}
+
+class PartitioningCreateRequestUnitTests extends AnyFunSuiteLike {
+
+  private val partitioning: PartitioningDTO = Seq(PartitionDTO("key", "value"))
+  private val parent: PartitioningDTO = Seq(PartitionDTO("parentKey", "parentValue"))
+
+  test("Single-parent convenience factory wraps a defined parent into a one-element Seq") {
+    val request = PartitioningCreateRequest(partitioning, Some(parent), "author")
+    assert(request == PartitioningCreateRequest(partitioning, Seq(parent), "author", copyMeasureDefinitions = false))
+  }
+
+  test("Single-parent convenience factory produces an empty Seq when there is no parent") {
+    val request = PartitioningCreateRequest(partitioning, None, "author")
+    assert(request == PartitioningCreateRequest(partitioning, Seq.empty, "author", copyMeasureDefinitions = false))
+  }
+
+  test("Primary constructor defaults copyMeasureDefinitions to false") {
+    val request = PartitioningCreateRequest(partitioning, Seq(parent), "author")
+    assert(!request.copyMeasureDefinitions)
+  }
+
+  test("Primary constructor honours an explicit copyMeasureDefinitions flag") {
+    val request = PartitioningCreateRequest(partitioning, Seq(parent), "author", copyMeasureDefinitions = true)
+    assert(request.copyMeasureDefinitions)
+  }
+
+}

jmf-rules.txt

@@ -182,6 +182,7 @@ za.co.absa.atum.server.api.v2.service.PartitioningService$#*
 za.co.absa.atum.server.implicits.SeqImplicits*#*
 za.co.absa.atum.model.envelopes.Pagination#*
 za.co.absa.atum.model.dto.PartitioningParentPatchDTO*#*
+za.co.absa.atum.server.model.database.CreatedPartitioningFromDB*#*
 za.co.absa.atum.model.ApiPaths*#*
 za.co.absa.atum.model.envelopes.ResponseEnvelope#*
 za.co.absa.atum.model.envelopes.StatusResponse#*

model/src/test/scala/za/co/absa/atum/model/dto/PartitioningSubmitV2DTOUnitTests.scala

@@ -0,0 +1,72 @@
+/*
+ * Copyright 2021 ABSA Group Limited
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package za.co.absa.atum.model.dto
+
+import io.circe.parser._
+import io.circe.syntax._
+import org.scalatest.funsuite.AnyFunSuiteLike
+
+class PartitioningSubmitV2DTOUnitTests extends AnyFunSuiteLike {
+
+  private val partitioning: PartitioningDTO = Seq(PartitionDTO("key", "value"))
+
+  test("Single-parent compatibility factory wraps the id in a Seq") {
+    val withParent = PartitioningSubmitV2DTO(partitioning, Some(1L), "author")
+    assert(withParent == PartitioningSubmitV2DTO(partitioning, Seq(1L), "author"))
+
+    val withoutParent = PartitioningSubmitV2DTO(partitioning, None, "author")
+    assert(withoutParent == PartitioningSubmitV2DTO(partitioning, Seq.empty, "author"))
+  }
+
+  test("Default copyMeasureDefinitions is false when not specified") {
+    val dto = PartitioningSubmitV2DTO(partitioning, Seq(1L), "author")
+    assert(!dto.copyMeasureDefinitions)
+  }
+
+  test("Decoder merges legacy parentPartitioningId with parentPartitioningIds and de-duplicates") {
+    val json =
+      """{
+        |  "partitioning": [{"key": "key", "value": "value"}],
+        |  "parentPartitioningId": 1,
+        |  "parentPartitioningIds": [1, 2],
+        |  "author": "author",
+        |  "copyMeasureDefinitions": true
+        |}""".stripMargin
+
+    val decoded = decode[PartitioningSubmitV2DTO](json)
+    assert(decoded == Right(PartitioningSubmitV2DTO(partitioning, Seq(1L, 2L), "author", copyMeasureDefinitions = true)))
+  }
+
+  test("Decoder defaults copyMeasureDefinitions to false and parents to empty when absent") {
+    val json =
+      """{
+        |  "partitioning": [{"key": "key", "value": "value"}],
+        |  "author": "author"
+        |}""".stripMargin
+
+    val decoded = decode[PartitioningSubmitV2DTO](json)
+    assert(decoded == Right(PartitioningSubmitV2DTO(partitioning, Seq.empty, "author", copyMeasureDefinitions = false)))
+  }
+
+  test("Encoder round-trips a decoded DTO") {
+    val dto = PartitioningSubmitV2DTO(partitioning, Seq(1L, 2L), "author", copyMeasureDefinitions = true)
+    val encoded = dto.asJson
+    assert(decode[PartitioningSubmitV2DTO](encoded.noSpaces) == Right(dto))
+    assert(encoded.hcursor.downField("parentPartitioningIds").as[Seq[Long]] == Right(Seq(1L, 2L)))
+  }
+
+}