Skip to content

[feature] : Tweak: Default config: Remove the below thresholds (since they now always run) #1332

@SylviaWhittle

Description

@SylviaWhittle

Is your feature request related to a problem?

In the new refactor version of TopoStats, with the removal of the grains.direction parameter, both the above and below options for each threshold are applied (correctly). But the default still runs a below threshold since it's set.

Image

Describe the solution you would like.

Remove the below values from the default config since it's so rare that it will be used.

Additionally, I had envisioned that the whole above and below keys be removed in #1235 but it never got merged due to conflicts with the refactor.

I only bring this up because I have lost some time to tracing a bug that was caused by inadvertently running the below as well as above accidentally.

Describe the alternatives you have considered.

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions